lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/11] fuse: Trust kernel i_mtime only -v2
On Thu, Dec 26, 2013 at 07:41:41PM +0400, Maxim Patlasov wrote:
> >>+
> >>+ if (!err)
> >>+ clear_bit(FUSE_I_MTIME_DIRTY, &fi->state);
> >Doing the test and the clear separately opens a huge race window when i_mtime
> >modifications are bound to get lost.
>
> No. Because the whole operation is protected by i_mutex (see
> fuse_fsync_common()).

fuse_release_common() doesn't have i_mutex. It's probably safe to acquire it,
but is that really needed?

Thanks,
Miklos


\
 
 \ /
  Last update: 2014-01-06 17:41    [W:0.270 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site