lkml.org 
[lkml]   [2014]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Intel-gfx] Excessive WARN()s in Intel 915 driver
    On Thu, Jan 30, 2014 at 09:53:54AM -0500, Alan Stern wrote:
    > On Tue, 28 Jan 2014, Daniel Vetter wrote:
    >
    > > I think I need a bit more debug output first. Can you please apply the
    > > below patch to drm-intel-nightly and then grab a drm.debug=0xe dmesg from
    > > boot?
    >
    > The dmesg output is below. Since you didn't say whether this should go
    > on top of the previous patch or in place of it, I put this in place of
    > the first one.
    >
    > BTW, I had to fix a bug in the patch:
    >
    > > @@ -9171,6 +9181,11 @@ intel_modeset_affected_pipes(struct drm_crtc *crtc, unsigned *modeset_pipes,
    > > *disable_pipes |= 1 << intel_crtc->pipe;
    > > else
    > > *prepare_pipes |= 1 << intel_crtc->pipe;
    > > +
    > > + DRM_DEBUG_KMS("[CRTC:%d:%s]: prepare_pipes %u\n",
    > > + intel_crtc->base.base.id,
    > > + pipe_name(intel_crtc->pipe),
    > > + *prepare_pipes);
    > > }
    >
    > pipe_name() returns char, not char *. I changed the output format
    > specifier from %s to %c.

    Ok, I seem to have been truly blind all the time. This seems to have been
    fallout from

    commit b6c5164d7bf624f3e1b750787ddb983150c5117c
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
    Date: Fri Apr 12 18:48:43 2013 +0200

    drm/i915: Fixup Oops in the pipe config computation

    Meanwhile we've moved the overall infrastructure ahead again quite a bit,
    so I think it's time to give the full atomic modeset paths another shot.
    But I'll be travelling to fosdem the next few days, so this will take a
    bit of time.

    As long as there's not real bad side-effects I guess we simply need to
    live with the WARN for a tad longer.
    -Daniel
    --
    Daniel Vetter
    Software Engineer, Intel Corporation
    +41 (0) 79 365 57 48 - http://blog.ffwll.ch


    \
     
     \ /
      Last update: 2014-01-30 16:41    [W:4.988 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site