Messages in this thread | | | Date | Wed, 29 Jan 2014 08:19:53 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug(). |
| |
* Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
> Hi Ingo, > On 01/28/2014 07:48 PM, Ingo Molnar wrote: > > > > > * David Rientjes <rientjes@google.com> wrote: > > > >> On Tue, 28 Jan 2014, Tang Chen wrote: > >> > >>> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() > >>> was not initialized. So we need to initialize it. > >>> > >>> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > >>> Tested-by: Gu Zheng <guz.fnst@cn.fujitsu.com> > >> > >> Reported-by: David Rientjes <rientjes@google.com> > > > > Agreed. Tang Chen, please also spell it out in the changelog: > > > > David Rientjes reported a boot crash, caused by > > commit XYZ ("foo: bar"). > > > > I find it somewhat annoying that you found time to credit a corporate > > collegue with a Tested-by tag, who didn't even reply to the whole > > thread to indicate his testing efforts, > > Sorry for missing to indicate the test result, because I am really > busy with some thorny issues. If Tang did not remind me, maybe I'll > miss the whole thread. But I think the "Tested-by:" is the best > confirmation of the testing efforts, it indicates that the guy has > nearly completely tested the patch on his environment.
Thanks for the effort!
Ingo
| |