Messages in this thread | | | Date | Wed, 29 Jan 2014 11:47:12 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 6/8] cgroup: remove cgroup->name |
| |
On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote: > cgroup->name handling became quite complicated over time involving > dedicated struct cgroup_name for RCU protection. Now that cgroup is > on kernfs, we can drop all of it and simply use kernfs_name/path() and > friends. Replace cgroup->name and all related code with kernfs > name/path constructs. > > * Reimplement cgroup_name() and cgroup_path() as thin wrappers on top > of kernfs counterparts, which involves semantic changes. > pr_cont_cgroup_name() and pr_cont_cgroup_path() added. > > * cgroup->name handling dropped from cgroup_rename(). > > * All users of cgroup_name/path() updated to the new semantics. Users > which were formatting the string just to printk them are converted > to use pr_cont_cgroup_name/path() instead, which simplifies things > quite a bit. As cgroup_name() no longer requires RCU read lock > around it, RCU lockings which were protecting only cgroup_name() are > removed. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Li Zefan <lizefan@huawei.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Balbir Singh <bsingharora@gmail.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
| |