Messages in this thread | | | Subject | Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address | From | Ian Campbell <> | Date | Tue, 28 Jan 2014 09:35:46 +0000 |
| |
On Tue, 2014-01-28 at 01:03 +0000, Julien Grall wrote: > On ARM, address size can be 32 bits or 64 bits (if CONFIG_ARCH_PHYS_ADDR_T_64BIT > is enabled). > We can't assume that the grant frame base address will always fits in an > unsigned long. Use phys_addr_t instead of unsigned long as argument for > gnttab_setup_auto_xlat_frames.
Strictly speaking I think it would be wrong for the tools to provide a grant frame address which only kernels with LPAE support enabled could use, so the issue is more theoretical than a real danger.
The patch is still correct though.
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
| |