lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
> >> If CONFIG_PM_SLEEP=n:
> >>
> >> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
> >> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> ---
> >> drivers/mfd/max14577.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> >> index ac514fb2b877..71aa14a6bfbb 100644
> >> --- a/drivers/mfd/max14577.c
> >> +++ b/drivers/mfd/max14577.c
> >> @@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
> >> };
> >> MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
> >>
> >> +#ifdef CONFIG_PM_SLEEP
> >> static int max14577_suspend(struct device *dev)
> >> {
> >> struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
> >> @@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
> >>
> >> return 0;
> >> }
> >> +#endif /* CONFIG_PM_SLEEP */
> >>
> >> static struct of_device_id max14577_dt_match[] = {
> >> { .compatible = "maxim,max14577", },
> >
> > Same here:
> > http://thread.gmane.org/gmane.linux.kernel/1615513/focus=1615563
> > although I don't mind if your patch comes in :).
>
> Sorry, missed those.
> It's a pity these known fixes don't go in together with the code that introduces
> them...

Great idea. Can I borrow your time machine? ;)

Or, we can use the -rcs, as this is what they were designed for.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-01-27 11:41    [W:0.070 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site