Messages in this thread | | | Date | Mon, 27 Jan 2014 00:35:59 -0800 (PST) | Subject | Re: [PATCH net] net: hyperv: initialize link status correctly | From | David Miller <> |
| |
From: Jason Wang <jasowang@redhat.com> Date: Mon, 27 Jan 2014 15:30:54 +0800
> Call netif_carrier_on() after register_device(). Otherwise it won't work since > the device was still in NETREG_UNINITIALIZED state. > > Fixes a68f9614614749727286f675d15f1e09d13cb54a > (hyperv: Fix race between probe and open calls) > > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: K. Y. Srinivasan <kys@microsoft.com> > Reported-by: Di Nie <dnie@redhat.com> > Tested-by: Di Nie <dnie@redhat.com> > Signed-off-by: Jason Wang <jasowang@redhat.com>
A device up can occur at the moment you call register_netdevice(), therefore that up call can see the carrier as down and fail or similar. So you really cannot resolve the carrier to be on in this way.
| |