lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak
On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote:
> On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote:
> > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.glpk@gmx.de wrote:
> > > From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > >
> > > p is freed if NULL.
> >
> > Not a real problem, right?
> >
> > > p is leaked if second calloc fails.
> >
> > You just created a new bug in your "fix" :(
> >
> > Please run your patches through scripts/checkpatch.pl, odds are, it
> > would have caught this error.
> >
>
> Checkpatch doesn't catch the problems here. I thought it would have
> caught the style issue but apparently it only looks for extra curly
> braces when you run it in --file mode.

Ah, that's good to know.

> Fengguang would hopefully have caught the missing curly braces bug with
> Coccinelle.

Is Coccinelle run on the userspace .c code in the kernel?

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-01-28 00:41    [W:0.041 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site