Messages in this thread Patch in this message | | | From | Tomas Winkler <> | Subject | [char-misc 1/2] mei: clear write cb from waiting list on reset | Date | Mon, 27 Jan 2014 22:27:23 +0200 |
| |
From: Alexander Usyskin <alexander.usyskin@intel.com>
Clear write callbacks sitting in write_waiting list on reset. Otherwise these callbacks are left dangling and cause memory leak.
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- drivers/misc/mei/client.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index ae07c38..8bf2034 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -960,8 +960,16 @@ void mei_cl_all_wakeup(struct mei_device *dev) void mei_cl_all_write_clear(struct mei_device *dev) { struct mei_cl_cb *cb, *next; + struct list_head *list; - list_for_each_entry_safe(cb, next, &dev->write_list.list, list) { + list = &dev->write_list.list; + list_for_each_entry_safe(cb, next, list, list) { + list_del(&cb->list); + mei_io_cb_free(cb); + } + + list = &dev->write_waiting_list.list; + list_for_each_entry_safe(cb, next, list, list) { list_del(&cb->list); mei_io_cb_free(cb); } -- 1.8.5.3
| |