lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [lm-sensors] lm90 driver no longer working on PCs in 3.13
On 01/26/2014 04:51 PM, Mark Brown wrote:
> On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
>
>> I think I have a better idea: Surround the regulator code, or at least
>> its error handling, in the lm90 driver with
>
>> if (IS_ENABLED(CONFIG_OF)) {
>> }
>
>> Would that be ok ? If yes I'll submit a patch. I'll do the same in
>> another driver I am working on.
>
> That's not going to have the desired effect in cases where DT is built
> into the kernel but not in use on the current system (which is a
> configuration that gets used) ...

The solution to that particular aspect of the problem is the following:

if (of_have_populated_dt()) {
...

which is a run-time rather than compile-time test.



\
 
 \ /
  Last update: 2014-01-27 19:01    [W:0.901 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site