Messages in this thread | | | Date | Mon, 27 Jan 2014 16:14:24 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH] perf tools: demangle kernel and kernel module symbols too |
| |
On 01/22/2014 09:58 PM, Avi Kivity wrote: > Some kernels contain C++ code, and thus their symbols need to be demangled. > This allows 'perf kvm top' to generate readable output.
Ping?
> Signed-off-by: Avi Kivity <avi@cloudius-systems.com> > --- > tools/perf/util/symbol-elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c > index 7594567..8f12f0f 100644 > --- a/tools/perf/util/symbol-elf.c > +++ b/tools/perf/util/symbol-elf.c > @@ -922,6 +922,7 @@ int dso__load_sym(struct dso *dso, struct map *map, > (u64)shdr.sh_offset); > sym.st_value -= shdr.sh_addr - shdr.sh_offset; > } > +new_symbol: > /* > * We need to figure out if the object was created from C++ sources > * DWARF DW_compile_unit has this, but we don't always have access > @@ -933,7 +934,6 @@ int dso__load_sym(struct dso *dso, struct map *map, > if (demangled != NULL) > elf_name = demangled; > } > -new_symbol: > f = symbol__new(sym.st_value, sym.st_size, > GELF_ST_BIND(sym.st_info), elf_name); > free(demangled);
| |