lkml.org 
[lkml]   [2014]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, mm: Avoid extra pxm_to_node()
On Sun, 26 Jan 2014, Yinghai Lu wrote:

> Index: linux-2.6/arch/x86/mm/srat.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/mm/srat.c
> +++ linux-2.6/arch/x86/mm/srat.c
> @@ -50,14 +50,19 @@ static __init inline int srat_disabled(v
> void __init acpi_numa_slit_init(struct acpi_table_slit *slit)
> {
> int i, j;
> + int from_node, to_node;
>
> for (i = 0; i < slit->locality_count; i++) {
> - if (pxm_to_node(i) == NUMA_NO_NODE)
> + from_node = pxm_to_node(i);
> + if (from_node == NUMA_NO_NODE)
> continue;
> +
> for (j = 0; j < slit->locality_count; j++) {
> - if (pxm_to_node(j) == NUMA_NO_NODE)
> + to_node = pxm_to_node(j);
> + if (to_node == NUMA_NO_NODE)
> continue;
> - numa_set_distance(pxm_to_node(i), pxm_to_node(j),
> +
> + numa_set_distance(from_node, to_node,
> slit->entry[slit->locality_count * i + j]);
> }
> }

Might as well make them "const" while you're at it by moving the
definitions inside the iteration blocks.


\
 
 \ /
  Last update: 2014-01-26 10:41    [W:1.109 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site