Messages in this thread | | | Date | Sun, 26 Jan 2014 21:22:57 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] afs: proc cells and rootcell are writeable |
| |
* Ingo Molnar <mingo@kernel.org> wrote:
> Perhaps we could also generate the most common variants as: > > #define PERM__rw_r__r__ 0644 > #define PERM__r________ 0400 > #define PERM__r__r__r__ 0444 > #define PERM__r_xr_xr_x 0555 > > etc. > > or something similar, more or less matching the output of 'ls -l'? > > That would also make security bugs in this area apparent at first > sight. The number of people who can recognize during review that > PERM_rw__w__w is probably unwise is probably two orders of magnitude > than those who can interpret octal 0622 at a glance. ^--higher
Thanks,
Ingo
| |