lkml.org 
[lkml]   [2014]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectFix ccp_run_passthru_cmd dma variable assignments
    There are some suspicious looking lines of code in the new ccp driver, including
    one that assigns a variable to itself, and another that overwrites a previous assignment.

    This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'.
    I have no hardware to test this, so this is untested.

    Signed-off-by: Dave Jones <davej@fedoraproject.org>

    diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
    index 71ed3ade7e12..c266a7b154bb 100644
    --- a/drivers/crypto/ccp/ccp-ops.c
    +++ b/drivers/crypto/ccp/ccp-ops.c
    @@ -1666,8 +1666,8 @@ static int ccp_run_passthru_cmd(struct ccp_cmd_queue *cmd_q,

    op.dst.type = CCP_MEMTYPE_SYSTEM;
    op.dst.u.dma.address = sg_dma_address(dst.sg_wa.sg);
    - op.src.u.dma.offset = dst.sg_wa.sg_used;
    - op.src.u.dma.length = op.src.u.dma.length;
    + op.dst.u.dma.offset = dst.sg_wa.sg_used;
    + op.dst.u.dma.length = op.src.u.dma.length;

    ret = ccp_perform_passthru(&op);
    if (ret) {

    \
     
     \ /
      Last update: 2014-01-24 20:21    [W:3.138 / U:0.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site