lkml.org 
[lkml]   [2014]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb
From
Date
On Wed, 2014-01-22 at 20:00 +0200, Sagi Grimberg wrote:
> On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote:
> > + cmd->prot_handover = PROT_SEPERATED;
> >> I know that we are not planning to support interleaved mode at the
> >> moment, But I think
> >> that the protection handover type is the backstore preference and should
> >> be taken from se_dev.
> >> But it is not that important for now...
> >>
> > Yeah, I figured since the RDMA pieces needed the handover type defined
> > in some form, it made sense to include PROT_SEPERATED hardcoded here,
> > but stopped short of adding se_dev->prot_handler for the first round
> > merge.
> >
> > --nab
> >
>
> Actually they don't, I just added them in iSER code to demonstrate the
> HW ability.
> If we are not planning to support that (although as MKP mentioned it
> might be useful in some cases),
> you can remove that for now and we can add it in the future - iSER can
> ignore it for now (I'll refactor the patches).
>

<nod>

I'll likely leave this in for the initial merge to avoid rebasing
target-pending/for-next now that the merge window is open.

Let's drop this bit in a separate incremental patch.

--nab



\
 
 \ /
  Last update: 2014-01-23 00:01    [W:0.084 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site