lkml.org 
[lkml]   [2014]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v6)
    On Tue, Jan 14, 2014 at 02:25:33PM +0900, Namhyung Kim wrote:
    > Hello,
    >
    > This is a new attempt to implement cumulative hist period report.
    > This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
    > rewrote it from scratch.
    >
    > This patchset is based on my previous patchset [2] but I think it's
    > almost independent so that it can be applied separately.
    >
    > Please see the patch 03/24. I refactored functions that add hist
    > entries with struct hist_entry_iter. While I converted all functions
    > carefully, it'd be better anyone can test and confirm that I didn't
    > mess up something - especially for branch stack and mem stuff.
    >
    > This patchset basically adds period in a sample to every node in the
    > callchain. A hist_entry now has an additional fields to keep the
    > cumulative period if --children option is given on perf report.
    >
    > I changed the option as a separate --children and added a new
    > "Children" column (and renamed the default "Overhead" column into
    > "Self"). The output will be sorted by children (cumulative) overhead
    > for now. The reason I changed to the --children is that I still think
    > it's much different from other --call-graph options. The --call-graph
    > option will take care of it even with --children option.
    >
    > I know that the UI should be changed also to be more flexible as Ingo
    > requested, but I'd like to do this first and then move to work on the
    > next. I also added a new config option to enable it by default.
    >
    > * changes in v6:
    > - separate struct hist_iter_ops (Jiri)
    > - check iter->he before calling ->add_entry_cb (Jiri)
    > - fix locking issue on perf top (Jiri)

    I have changes on top of this patchset and all looks great, I was
    just going throught this again and wanted to send my ack, but it
    no longer merges to the acme's perf/core.

    Could you please send updated version, and I'll finish the
    review.. I promise ;-)

    thanks,
    jirka


    \
     
     \ /
      Last update: 2014-01-22 15:01    [W:4.111 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site