Messages in this thread | | | Subject | Re: [PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls | From | "Nicholas A. Bellinger" <> | Date | Tue, 21 Jan 2014 14:17:45 -0800 |
| |
On Sun, 2014-01-19 at 14:12 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@linux-iscsi.org> > > > > This patch adds support to target_submit_cmd_map_sgls() for > > accepting 'sgl_prot' + 'sgl_prot_count' parameters for > > DIF protection information. > > > > Note the passed parameters are stored at se_cmd->t_prot_sg > > and se_cmd->t_prot_nents respectively. > > > > Also, update tcm_loop and vhost-scsi fabrics usage of > > target_submit_cmd_map_sgls() to take into account the > > new parameters. > > I didn't see that you added protection allocation to transports that > does not use > target_submit_cmd_map_sgls() - which happens to be iSCSI/iSER/SRP :( > > Don't you think that prot SG allocation should be added also to > target_alloc_sgl()? by then > se_cmd should contain the protection attributes and this routine can > know if it needs to > allocate prot_sg as well. This is how I used it...
Yes, this specific bit was left out for the moment as no code in the patch for v3.14 actually uses it..
I'm planning to add it to for-next -> v3.15 code as soon as the merge window closes.
--nab
| |