Messages in this thread | | | Subject | Re: [PATCH 1/2][v5] driver/memory:Move Freescale IFC driver to a common driver | From | Kumar Gala <> | Date | Tue, 21 Jan 2014 11:11:31 -0600 |
| |
On Jan 18, 2014, at 12:21 AM, Prabhakar Kushwaha <prabhakar@freescale.com> wrote:
> Freescale IFC controller has been used for mpc8xxx. It will be used > for ARM-based SoC as well. This patch moves the driver to driver/memory > and fix the header file includes. > > Also remove module_platform_driver() and instead call > platform_driver_register() from subsys_initcall() to make sure this module > has been loaded before MTD partition parsing starts. > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > --- > Changes for v2: > - Move fsl_ifc in driver/memory > > Changes for v3: > - move device tree bindings to memory > > Changes for v4: Rebased to > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git > > Changes for v5: > - Moved powerpc/Kconfig option to driver/memory > > > .../{powerpc => memory-controllers}/fsl/ifc.txt | 0 > arch/powerpc/Kconfig | 4 ---- > arch/powerpc/sysdev/Makefile | 1 - > drivers/memory/Kconfig | 4 ++++ > drivers/memory/Makefile | 1 + > {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c | 8 ++++++-- > drivers/mtd/nand/fsl_ifc_nand.c | 2 +- > .../include/asm => include/linux}/fsl_ifc.h | 0 > 8 files changed, 12 insertions(+), 8 deletions(-) > rename Documentation/devicetree/bindings/{powerpc => memory-controllers}/fsl/ifc.txt (100%) > rename {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c (98%) > rename {arch/powerpc/include/asm => include/linux}/fsl_ifc.h (100%) > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > similarity index 100% > rename from Documentation/devicetree/bindings/powerpc/fsl/ifc.txt > rename to Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index b44b52c..83fb8b3 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -725,10 +725,6 @@ config FSL_LBC > controller. Also contains some common code used by > drivers for specific local bus peripherals. > > -config FSL_IFC > - bool > - depends on FSL_SOC > - > config FSL_GTM > bool > depends on PPC_83xx || QUICC_ENGINE || CPM2 > diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile > index f67ac90..afbcc37 100644 > --- a/arch/powerpc/sysdev/Makefile > +++ b/arch/powerpc/sysdev/Makefile > @@ -21,7 +21,6 @@ obj-$(CONFIG_FSL_SOC) += fsl_soc.o fsl_mpic_err.o > obj-$(CONFIG_FSL_PCI) += fsl_pci.o $(fsl-msi-obj-y) > obj-$(CONFIG_FSL_PMC) += fsl_pmc.o > obj-$(CONFIG_FSL_LBC) += fsl_lbc.o > -obj-$(CONFIG_FSL_IFC) += fsl_ifc.o > obj-$(CONFIG_FSL_GTM) += fsl_gtm.o > obj-$(CONFIG_FSL_85XX_CACHE_SRAM) += fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o > obj-$(CONFIG_SIMPLE_GPIO) += simple_gpio.o > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index 29a11db..b33bb0e 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -50,4 +50,8 @@ config TEGRA30_MC > analysis, especially for IOMMU/SMMU(System Memory Management > Unit) module. > > +config FSL_IFC > + bool > + depends on FSL_SOC > +
I think this should be user selectable like all the other Kconfig options in drivers/memory
Also add a help description.
> endif
[ snip ]
- k
| |