Messages in this thread | | | Date | Tue, 21 Jan 2014 16:15:18 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 6/6] numa,sched: do statistics calculation using local variables only |
| |
On Mon, Jan 20, 2014 at 02:21:07PM -0500, riel@redhat.com wrote: > From: Rik van Riel <riel@redhat.com> > > The current code in task_numa_placement calculates the difference > between the old and the new value, but also temporarily stores half > of the old value in the per-process variables. > > The NUMA balancing code looks at those per-process variables, and > having other tasks temporarily see halved statistics could lead to > unwanted numa migrations. This can be avoided by doing all the math > in local variables. > > This change also simplifies the code a little. > > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Mel Gorman <mgorman@suse.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Chegu Vinod <chegu_vinod@hp.com> > Signed-off-by: Rik van Riel <riel@redhat.com>
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
| |