Messages in this thread | | | Date | Tue, 21 Jan 2014 11:19:15 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v8 4/6] MCS Lock: Move mcs_lock/unlock function into its own |
| |
On Mon, Jan 20, 2014 at 05:24:31PM -0800, Tim Chen wrote: > +EXPORT_SYMBOL_GPL(mcs_spin_lock); > +EXPORT_SYMBOL_GPL(mcs_spin_unlock);
Do we really need the EXPORTs? The only user so far is mutex and that's core code. The other planned users are rwsems and rwlocks, for both it would be in the slow path, which is also core code.
We should generally only add EXPORTs once theres a need.
| |