Messages in this thread | | | Date | Mon, 20 Jan 2014 14:23:21 +0900 | From | AKASHI Takahiro <> | Subject | Re: [PATCH v2 4/6] arm64: audit: Add 32-bit (compat) syscall support |
| |
On 01/18/2014 01:46 AM, Will Deacon wrote: > Hi Akashi, > > On Fri, Jan 17, 2014 at 08:13:17AM +0000, AKASHI Takahiro wrote: >> Generic audit code also support compat system calls now. >> This patch adds a small piece of architecture dependent code. > > [...] > >> static inline int syscall_get_nr(struct task_struct *task, >> @@ -109,6 +110,15 @@ static inline void syscall_set_arguments(struct task_struct *task, >> static inline int syscall_get_arch(struct task_struct *task, >> struct pt_regs *regs) >> { >> +#ifdef CONFIG_COMPAT >> + if (is_compat_thread(task_thread_info(task))) > > You can call is_compat_thread even when !CONFIG_COMPAT, so you don't need > that #ifdef.
Right. I will remove it.
>> +#ifdef __AARCH64EB__ >> + return AUDIT_ARCH_ARMEB; /* only BE on BE */ > > Well, actually, we only support userspace to be the same endianness as the > kernel, so you that comment is slightly misleading. You could probably avoid > these repeated ifdefs by defining things like ARM64_AUDIT_ARCH and > ARM64_COMPAT_AUDIT_ARCH once depending on endianness.
As in the discussions about "audit(userspace)", if we don't have to care about endianness, I will remove this #ifdef instead.
Thanks, -Takahiro AKASHI
> Will >
| |