Messages in this thread | | | Date | Fri, 3 Jan 2014 12:12:37 +0800 | From | Dave Young <> | Subject | Re: [PATCH v7 00/12] kexec kernel efi runtime support |
| |
> Please send these as separate patches and include the compiler errors in > the commit message. I'll pick them up and send them to Peter.
Sent.
> > > build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c > > Why have you moved the call site for parse_efi_setup()? What's the > rationale? Parsing SETUP_* entries outside of parse_setup_data() seems > to me to be a step backwards in terms of clarity.
SETUP_PCI also duplicate the parsing logic out of setup.c. I added static inline in ifdef else branch, but I got some warnings yestoday about "unused function", double checked it today there's no such warnings anymore, it might be caused by some mistake.
Changed to static inline {} in patches I just sent a moment ago.
Thanks Dave
| |