| Date | Thu, 2 Jan 2014 13:53:07 +0000 | From | David Vrabel <> | Subject | Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call |
| |
On 19/12/13 15:03, Levente Kurusa wrote: > This is required so that we give up the last reference to the device. > > Signed-off-by: Levente Kurusa <levex@linux.com> > --- > drivers/xen/xenbus/xenbus_probe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c > index 3c0a74b..4abb9ee 100644 > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -465,8 +465,10 @@ int xenbus_probe_node(struct xen_bus_type *bus, > > /* Register with generic device framework. */ > err = device_register(&xendev->dev); > - if (err) > + if (err) { > + put_device(&xendev->dev); > goto fail; > + } > > return 0; > fail:
There is a kfree(xendev) here so this introduces a double-free.
David
|