Messages in this thread | | | Date | Thu, 2 Jan 2014 13:37:43 +0100 | Subject | Re: [PATCH 4/6] ARM: tegra: rework fuse.c | From | Linus Walleij <> |
| |
On Thu, Dec 19, 2013 at 4:54 PM, Peter De Schrijver <pdeschrijver@nvidia.com> wrote:
> Reduce fuse.c to the minimum functionality required for the early bootstages. > Also export tegra_read_straps() for use by the fuse driver. > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Aha, but why?
> -static void __init tegra20_fuse_init_randomness(void) > -{ > - u32 randomness[2]; > - > - randomness[0] = tegra_fuse_readl(FUSE_UID_LOW); > - randomness[1] = tegra_fuse_readl(FUSE_UID_HIGH); > - > - add_device_randomness(randomness, sizeof(randomness)); > -} > - > -/* Applies to Tegra30 or later */ > -static void __init tegra30_fuse_init_randomness(void) > -{ > - u32 randomness[7]; > - > - randomness[0] = tegra_fuse_readl(FUSE_VENDOR_CODE); > - randomness[1] = tegra_fuse_readl(FUSE_FAB_CODE); > - randomness[2] = tegra_fuse_readl(FUSE_LOT_CODE_0); > - randomness[3] = tegra_fuse_readl(FUSE_LOT_CODE_1); > - randomness[4] = tegra_fuse_readl(FUSE_WAFER_ID); > - randomness[5] = tegra_fuse_readl(FUSE_X_COORDINATE); > - randomness[6] = tegra_fuse_readl(FUSE_Y_COORDINATE); > - > - add_device_randomness(randomness, sizeof(randomness)); > -}
We still want to get this into the random pool right? Can it not simply be moved to a later initcall then?
Yours, Linus Walleij
| |