lkml.org 
[lkml]   [2014]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH] ASoC: core: Use devm_kzalloc() instead kzalloc()
On 01/16/2014 09:44 AM, Xiubo Li wrote:
> Makes the code slightly shorter
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>

I don't like this. I don't think it is a good design pattern to call devm
function from within (especial non-devm) library functions. It creates an
asymmetric API. The memory is allocated when snd_dmaengine_pcm_register() is
called, but it is not freed when snd_dmaengine_pcm_unregister() is called.
This goes against the principle of least surprise.

- Lars

> ---
> sound/soc/soc-generic-dmaengine-pcm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
> index 5bace12..bfb012f 100644
> --- a/sound/soc/soc-generic-dmaengine-pcm.c
> +++ b/sound/soc/soc-generic-dmaengine-pcm.c
> @@ -388,7 +388,7 @@ int snd_dmaengine_pcm_register(struct device *dev,
> struct dmaengine_pcm *pcm;
> int ret;
>
> - pcm = kzalloc(sizeof(*pcm), GFP_KERNEL);
> + pcm = devm_kzalloc(dev, sizeof(*pcm), GFP_KERNEL);
> if (!pcm)
> return -ENOMEM;
>
> @@ -408,7 +408,6 @@ int snd_dmaengine_pcm_register(struct device *dev,
>
> err_free_dma:
> dmaengine_pcm_release_chan(pcm);
> - kfree(pcm);
> return ret;
> }
> EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_register);
> @@ -433,7 +432,6 @@ void snd_dmaengine_pcm_unregister(struct device *dev)
>
> snd_soc_remove_platform(platform);
> dmaengine_pcm_release_chan(pcm);
> - kfree(pcm);
> }
> EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_unregister);
>
>



\
 
 \ /
  Last update: 2014-01-16 23:21    [W:0.062 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site