lkml.org 
[lkml]   [2014]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/17] tools lib traceevent: Unregister handler when jbd2 plugin unloaded
    On Wed, 15 Jan 2014 10:45:38 +0900
    Namhyung Kim <namhyung@kernel.org> wrote:

    > The function handlers should be unregistered when the plugin unloaded
    > otherwise they'll try to access invalid memory.
    >
    > Cc: Jiri Olsa <jolsa@redhat.com>
    > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    > ---
    > tools/lib/traceevent/plugin_jbd2.c | 11 +++++++++++
    > 1 file changed, 11 insertions(+)
    >
    > diff --git a/tools/lib/traceevent/plugin_jbd2.c b/tools/lib/traceevent/plugin_jbd2.c
    > index 2f93f81f0bac..88fe6fe872d5 100644
    > --- a/tools/lib/traceevent/plugin_jbd2.c
    > +++ b/tools/lib/traceevent/plugin_jbd2.c
    > @@ -66,3 +66,14 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
    > PEVENT_FUNC_ARG_VOID);
    > return 0;
    > }
    > +
    > +void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
    > +{
    > + pevent_unregister_print_function(pevent,
    > + process_jbd2_dev_to_name,
    > + "jbd2_dev_to_name");
    > +
    > + pevent_unregister_print_function(pevent,
    > + process_jiffies_to_msecs,
    > + "jiffies_to_msecs");
    > +}

    Same here. I don't know about others, but I think it looks a bit nicer
    if we move the function up to the first line.

    -- Steve



    \
     
     \ /
      Last update: 2014-01-15 22:21    [W:4.712 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site