Messages in this thread | | | Date | Wed, 15 Jan 2014 15:34:42 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 14/17] tools lib traceevent: Unregister handler when cfg80211 plugin unloaded |
| |
On Wed, 15 Jan 2014 10:45:37 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> The function handler should be unregistered when the plugin unloaded > otherwise it'll try to access invalid memory. > > Cc: Jiri Olsa <jolsa@redhat.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/lib/traceevent/plugin_cfg80211.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c > index dcab8e873c21..7b07d149557b 100644 > --- a/tools/lib/traceevent/plugin_cfg80211.c > +++ b/tools/lib/traceevent/plugin_cfg80211.c > @@ -22,3 +22,10 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent) > PEVENT_FUNC_ARG_VOID); > return 0; > } > + > +void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent) > +{ > + pevent_unregister_print_function(pevent, > + process___le16_to_cpup, > + "__le16_to_cpup"); > +}
Can we format this a little nicer:
pevent_unregister_print_function(pevent, process___le16_to_cpup, "__le16_to_cpup");
I know the register had that separated, but that's because it had args too, and it made it look nicer. But this don't work here. It looks odd.
-- Steve
| |