lkml.org 
[lkml]   [2014]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH tip/core/timers 2/4] timers: Reduce __run_timers() latency for empty list
forgot to mention...

On 01/14, Paul E. McKenney wrote:
>
> +static bool catchup_timer_jiffies(struct tvec_base *base)
> +{
> +#ifdef CONFIG_NO_HZ_FULL
> + if (!base->all_timers) {
> + base->timer_jiffies = jiffies;
> + return 1;
> + }
> +#endif /* #ifdef CONFIG_NO_HZ_FULL */
> + return 0;
> +}

Do we really want ifdef?

This check is cheap, and !CONFIG_NO_HZ_FULL case looks a bit
strange because we still update ->all_timers for no reason.

Oleg.



\
 
 \ /
  Last update: 2014-01-15 19:21    [W:0.178 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site