| Date | Wed, 15 Jan 2014 18:38:58 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH tip/core/timers 2/4] timers: Reduce __run_timers() latency for empty list |
| |
forgot to mention...
On 01/14, Paul E. McKenney wrote: > > +static bool catchup_timer_jiffies(struct tvec_base *base) > +{ > +#ifdef CONFIG_NO_HZ_FULL > + if (!base->all_timers) { > + base->timer_jiffies = jiffies; > + return 1; > + } > +#endif /* #ifdef CONFIG_NO_HZ_FULL */ > + return 0; > +}
Do we really want ifdef?
This check is cheap, and !CONFIG_NO_HZ_FULL case looks a bit strange because we still update ->all_timers for no reason.
Oleg.
|