Messages in this thread | | | Date | Wed, 15 Jan 2014 18:24:09 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH tip/core/timers 4/4] timers: Reduce future __run_timers() latency for first add to empty list |
| |
On 01/14, Paul E. McKenney wrote: > > @@ -749,6 +749,7 @@ __mod_timer(struct timer_list *timer, unsigned long expires, > > base = lock_timer_base(timer, &flags); > > + (void)catchup_timer_jiffies(base);
Agreed, but perhaps it would be better to do this before all_timers++ in internal_add_timer() ?
This is funny, but I already have the same change for ->next_timer, if we add this optimization perhaps that trivial patch makes sense too.
Oleg.
| |