lkml.org 
[lkml]   [2014]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/4]zram: locking redesign
On (01/15/14 10:11), Minchan Kim wrote:
> Currently, zram->lock rw_semaphore is coarse-grained so it hurts
> for scalability.
> This patch try to enhance it with remove the lock in read path.
>
> [1] uses atomic opeartion so it removes dependency of 32bit stat
> from zram->lock.
> [2] introduces table own lock instead of relying on zram->lock.
> [3] remove free pending slot mess so it makes core very clean.
> [4] finally removes zram->lock in read path and changes it with mutex.
>
> So, output is wonderful. read/write mixed workload performs well
> 11 times than old and write concurrency is also enhanced because
> mutex supports SPIN_ON_OWNER while rw_semaphore doesn't yet.
> (I know recenty there were some effort to enhance it for rw_semaphore
> from Tim Chen but not sure it got merged. Anyway, we don't need it
> any more and there is no reason to prevent read-write concurrency)
>
> Thanks.
>

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

> Minchan Kim (4):
> [1] zram: use atomic operation for stat
> [2] zram: introduce zram->tb_lock
> [3] zram: remove workqueue for freeing removed pending slot
> [4] zram: Remove zram->lock in read path and change it with mutex
>
> drivers/staging/zram/zram_drv.c | 117 ++++++++++++++++------------------------
> drivers/staging/zram/zram_drv.h | 27 +++-------
> 2 files changed, 51 insertions(+), 93 deletions(-)
>
> --
> 1.8.5.2
>


\
 
 \ /
  Last update: 2014-01-15 11:01    [W:0.062 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site