lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints
From
Date
On Wed, 2014-01-15 at 00:52 -0200, Fabio Estevam wrote:
> Fix the following checkpatch error and warning:

While you're at it:

> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
[]
> @@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
[]
> + case 0x8:
> + dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");

missing "\n" terminating newline and
missing break (or fallthrough comment)

> + case 0x0:
> + break;
> + default:
> + dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);

invalid vs illegal




\
 
 \ /
  Last update: 2014-01-15 04:41    [W:0.033 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site