Messages in this thread | | | Date | Tue, 14 Jan 2014 18:48:47 -0800 (PST) | From | David Rientjes <> | Subject | Re: [RFC][PATCH 4/9] mm: slabs: reset page at free |
| |
On Tue, 14 Jan 2014, Dave Hansen wrote:
> diff -puN include/linux/mm.h~slub-reset-page-at-free include/linux/mm.h > --- a/include/linux/mm.h~slub-reset-page-at-free 2014-01-14 09:57:57.099666808 -0800 > +++ b/include/linux/mm.h 2014-01-14 09:57:57.110667301 -0800 > @@ -2076,5 +2076,16 @@ static inline void set_page_pfmemalloc(s > page->index = pfmemalloc; > } > > +/* > + * Custom allocators (like the slabs) use 'struct page' fields > + * for all kinds of things. This resets the page's state so that > + * the buddy allocator will be happy with it. > + */ > +static inline void allocator_reset_page(struct page *page)
This is ambiguous as to what "allocator" you're referring to unless we look at the comment. I think it would be better to name it slab_reset_page() or something similar.
> +{ > + page->mapping = NULL; > + page_mapcount_reset(page); > +} > + > #endif /* __KERNEL__ */ > #endif /* _LINUX_MM_H */
| |