lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86: intel-mid: sfi_handle_*_dev() should check for pdata error code
Hi Ingo,

On Fri, Dec 20, 2013 at 09:49:53AM +0100, Ingo Molnar wrote:
>
> * David Cohen <david.a.cohen@linux.intel.com> wrote:
>
> > Prevent sfi_handle_*_dev() to register device in case
> > intel_mid_sfi_get_pdata() failed to execute.
> >
> > Since 'NULL' is a valid return value, this patch makes
> > sfi_handle_*_dev() functions to use IS_ERR() to validate returned pdata.
>
> Is this bug triggering in practice? If not then please say so in the
> changelog. If yes then is this patch desired for v3.13 merging and
> also please fix the changelog to conform to the standard changelog
> style:
>
> - first describe the symptoms of the bug - how does a user notice?
>
> - then describe how the code behaves today and how that is causing
> the bug
>
> - and then only describe how it's fixed.
>
> The first item is the most important one - while developers
> (naturally) tend to concentrate on the least important point, the last
> one.

Thanks for the feedback :)
This new patch set was done in reply to your comment:
https://lkml.org/lkml/2013/12/20/517

Br, David Cohen

>
> Thanks,
>
> Ingo


\
 
 \ /
  Last update: 2014-01-15 02:01    [W:0.236 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site