lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] mmc: add Toshiba PCI SD controller driver

> + pr_debug("Command IRQ complete %d %d %x\n", cmd->opcode, cmd->error,
> + cmd->flags);

dev_dbg... (and a few other places)


> +/* Set MMC clock / power.
> + * Note: This controller uses a simple divider scheme therefore it cannot run
> + * SD/MMC cards at full speed (24/20MHz). HCLK (=33MHz PCI clock?) is too high
> + * and the next slowest is 16MHz (div=2).
> + */
> +static void toshsd_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)

This has some very long delays with interrupts off from the
spin_lock_irqsave. I guess thats hardly #1 priority though nor a killer.


> + /* reset */
> + toshsd_writew(host, SD_SOFTWARERESET, 0); /* assert */
> + mdelay(2);
> + toshsd_writew(host, SD_SOFTWARERESET, 1); /* deassert */
> + mdelay(2);

This doesn't do quite what you might think - if the device is mmio mapped
then the write can be posted so the mdelay(2) may not be 2mS. I guess if
the old driver didn't do it then it was already plenty long enough...


> + base = pci_resource_start(pdev, 0);
> + dev_info(&pdev->dev, "MMIO %pa, IRQ %d\n", &base, pdev->irq);

dbg



\
 
 \ /
  Last update: 2014-01-15 01:21    [W:0.044 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site