lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource
Date
On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote:
> On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote:
> > devm_ioremap_resource does sanity checks on the given resource. No need to
> > duplicate this in the driver.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
>
> True that,
>
> Acked-by: Marek Vasut <marex@denx.de>

(+cc Fabio Estevam)

Hi all,

The same patch was already sent by Fabio Estevam a month ago.[1]
Also, it was applied to pci/next tree.[2]

[1] http://www.spinics.net/lists/linux-pci/msg26873.html
[2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586

Best regards,
Jingoo Han

>
> > ---
> >
> > Should go via subsystem tree
> >
> > drivers/pci/host/pci-imx6.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> > index bd70af8..5002e23 100644
> > --- a/drivers/pci/host/pci-imx6.c
> > +++ b/drivers/pci/host/pci-imx6.c
> > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
> > platform_device *pdev) "imprecise external abort");
> >
> > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - if (!dbi_base) {
> > - dev_err(&pdev->dev, "dbi_base memory resource not found\n");
> > - return -ENODEV;
> > - }
> > -
> > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
> > if (IS_ERR(pp->dbi_base)) {
> > ret = PTR_ERR(pp->dbi_base);
>
> Best regards,
> Marek Vasut



\
 
 \ /
  Last update: 2014-01-15 00:01    [W:1.335 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site