lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Staging: comedi: move trailing statement to next line in ni_mio_common.c
    On Mon, Jan 13, 2014 at 07:16:14PM -0800, Joe Perches wrote:
    > On Mon, 2014-01-13 at 21:13 -0600, Chase Southwood wrote:
    > > This patch for ni_mio_common.c silences a checkpatch error due to a
    > > trailing statement.
    > []
    > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
    > []
    > > @@ -692,7 +692,8 @@ static void ni_clear_ai_fifo(struct comedi_device *dev)
    > > /* Flush the 6143 data FIFO */
    > > ni_writel(0x10, AIFIFO_Control_6143); /* Flush fifo */
    > > ni_writel(0x00, AIFIFO_Control_6143); /* Flush fifo */
    > > - while (ni_readl(AIFIFO_Status_6143) & 0x10) ; /* Wait for complete */
    > > + while (ni_readl(AIFIFO_Status_6143) & 0x10)
    > > + ; /* Wait for complete */
    >
    > It's generally better to use timeouts too.

    Just to clarify what Joe is saying do:

    /* Wait for complete */
    while (timemout < TIMEOUT) {
    if (ni_readl(AIFIFO_Status_6143) & 0x10)
    break;
    udelay(1);
    }

    I added in a delay... The problem is that you'd probably have to look
    at the hardware spec to know what timeout to use or if the delay is
    needed.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2014-01-14 09:01    [W:4.480 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site