Messages in this thread | | | Date | Mon, 13 Jan 2014 22:59:52 -0800 (PST) | From | Kuninori Morimoto <> | Subject | Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data |
| |
Hi Xiubo
Thank you for your patch
> Whether the dt is used or not, almost all the simple card information > for the DAI link and sound card are initialized in the simple card driver. > > And for the platform caller, the snd_link and snd_card are of no use, so > move them from struct asoc_simple_card_info to struct asoc_simple_card_data. > > And now only one DAI link is supported for simple card. > > Suggested-by: Jean-Francois Moine <moinejf@free.fr> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > ---
This patch seems have many this kind of lines - info->xxx + sdata->info->xxx
But, how about add this line to each function ?
struct asoc_simple_card_info *info = &sdata->info;
Patch will be more readable
Best regards --- Kuninori Morimoto
| |