Messages in this thread | | | Date | Tue, 14 Jan 2014 07:48:22 -0800 | From | "H. Peter Anvin" <> | Subject | Re: linux-next: manual merge of the akpm-current tree with the tip tree |
| |
On 01/14/2014 07:41 AM, Peter Zijlstra wrote: >>> >>> I am *guessing* that m68k is has get_fs() == KERNEL_DS at the point that >>> futex_init() is called. This would seem a bit of a peculiarity to m68k, >>> and as such it would seem like it would be better for it to belong in >>> the m68k-specific code, but since futex_init() is init code and only >>> called once anyway it shouldn't cause any harm... >> >> Yes it does. So when getting the exception on 68030, we notice it's a kernel >> space access error, not a user space access error, and crash. > > Is there a good reason m68k works like this? That is, shouldn't we fix > the arch code instead of littering the generic code with weirdness like > this? >
Given that futex_init is called from initcall, this seems *really* weird on the part of m68k. I agree this should be fixed where the problem sits.
-hpa
| |