Messages in this thread | | | Date | Tue, 14 Jan 2014 11:48:18 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] Staging: comedi: move trailing statement to next line in ni_mio_common.c |
| |
On 2014-01-14 03:13, Chase Southwood wrote: > This patch for ni_mio_common.c silences a checkpatch error due to a > trailing statement. > > Signed-off-by: Chase Southwood <chase.southwood@yahoo.com> > --- > drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index 457b884..dba19e9 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -692,7 +692,8 @@ static void ni_clear_ai_fifo(struct comedi_device *dev) > /* Flush the 6143 data FIFO */ > ni_writel(0x10, AIFIFO_Control_6143); /* Flush fifo */ > ni_writel(0x00, AIFIFO_Control_6143); /* Flush fifo */ > - while (ni_readl(AIFIFO_Status_6143) & 0x10) ; /* Wait for complete */ > + while (ni_readl(AIFIFO_Status_6143) & 0x10) > + ; /* Wait for complete */ > } else { > devpriv->stc_writew(dev, 1, ADC_FIFO_Clear); > if (board->reg_type == ni_reg_625x) { >
As others mentioned, a timeout would be nice, but as this is just a clean-up patch, I think it's fine as-is.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |