lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
    Hi Wolfgang,

    should we take 1/7 and 6/7 via the mips tree ?

    John


    On 14/01/2014 12:58, Wolfram Sang wrote:
    > devm_ioremap_resource does sanity checks on the given resource. No need to
    > duplicate this in the driver.
    >
    > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    > Acked-by: John Crispin <blogic@openwrt.org>
    > ---
    >
    > Should go via subsystem tree
    >
    > arch/mips/lantiq/xway/dma.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
    > index 08f7ebd..78a91fa 100644
    > --- a/arch/mips/lantiq/xway/dma.c
    > +++ b/arch/mips/lantiq/xway/dma.c
    > @@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
    > int i;
    >
    > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > - if (!res)
    > - panic("Failed to get dma resource");
    > -
    > - /* remap dma register range */
    > ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
    > if (IS_ERR(ltq_dma_membase))
    > panic("Failed to remap dma resource");



    \
     
     \ /
      Last update: 2014-01-14 13:41    [W:2.472 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site