lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] iio: mxs-lradc: fix invalid channel number detection
    On 13/01/2014 21:25, Marek Vasut wrote:
    > On Monday, January 13, 2014 at 05:02:02 PM, Alexandre Belloni wrote:
    >> 16 would be accepted as a channel number but it is invalid. It doesn't
    >> really have any effect as mxs_lradc_read_raw is called from a "controlled"
    >> environment so it it only gets values going from 0 to 15.
    >>
    >> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
    >
    > Why don't you remove the check entirely then ?
    >

    I'm not quite sure the inkernel API is sanitizing the input correctly
    but maybe I didn't check enough. Maybe Jonathan can comment ?

    --
    Alexandre Belloni, Free Electrons
    Embedded Linux, Kernel and Android engineering
    http://free-electrons.com


    \
     
     \ /
      Last update: 2014-01-14 01:21    [W:4.861 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site