Messages in this thread | | | Date | Sun, 12 Jan 2014 10:30:13 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information |
| |
On Sun, Jan 12, 2014 at 05:20:03PM +0800, Qiaowei Ren wrote: > This patch adds new fields about bound violation into siginfo > structure. si_lower and si_upper are respectively lower bound > and upper bound when bound violation is caused. > > These fields will be set in #BR exception handler by decoding > the user instruction and constructing the faulting pointer. > A userspace application can get violation address, lower bound > and upper bound for bound violation from this new siginfo structure. > > Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com> > --- > arch/x86/include/asm/mpx.h | 39 +++++ > arch/x86/kernel/mpx.c | 289 ++++++++++++++++++++++++++++++++++++
This thing looks like a partial duplication of functionality which we already have - inat.*/insn.*, etc.
It would be cleaner to integrate the mpx pieces into the existing x86 insn analysis code and use it instead of growing your own, IMHO.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |