lkml.org 
[lkml]   [2013]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] filemap: add missing unlock_page
On Mon, Sep 09, 2013 at 04:18:22PM +0800, Hillf Danton wrote:
> Unlock and release page before returning error.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/filemap.c Mon Sep 9 15:51:28 2013
> +++ b/mm/filemap.c Mon Sep 9 15:52:54 2013
> @@ -1844,6 +1844,7 @@ retry:
> }
> err = filler(data, page);
> if (err < 0) {
> + unlock_page(page);
> page_cache_release(page);
> return ERR_PTR(err);
> }

NAK. filler() should unlock the page.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-09-09 11:01    [W:0.038 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site