Messages in this thread | | | Date | Mon, 09 Sep 2013 22:14:47 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test |
| |
On 09/09/13 16:23, Michael Hennerich wrote: > On 09/07/2013 10:44 PM, Jonathan Cameron wrote: >> ccing Michael Hennerich and Lars-Peter Clausen, > > Looks good to me! > > /Acked-by/: /Michael Hennerich/ <michael.hennerich@analog.com> Applied to the togreg branch of iio.git.
Thanks > >> >> On 09/06/13 16:20, Tejun Heo wrote: >>> On Fri, Sep 06, 2013 at 07:02:34PM +0800, Xie XiuQi wrote: >>>> Remove unnecessary work pending test before calling schedule_work(). >>>> It has been tested in queue_work_on() already. No functional changed. >>>> >>>> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com> >>>> Cc: Tejun Heo <tj@kernel.org> >>> Reviewed-by: Tejun Heo <tj@kernel.org> >>> >>> One nit below tho. >>> >>>> - if (iio_buffer_enabled(indio_dev)) { >>>> - if (!work_pending(&st->poll_work)) >>>> - schedule_work(&st->poll_work); >>>> - } else { >>>> + if (iio_buffer_enabled(indio_dev)) >>>> + schedule_work(&st->poll_work); >>>> + else { >>>> st->done = true; >>>> wake_up_interruptible(&st->wq_data_avail); >>>> } >>> Please don't drop the parentheses. The convention is to have either >>> both or none on if/else. >> I'll fix this up on applying if everyone is happy (can't see why the >> won't be, but best to check!) Michael is clearly given as the author of driver >> so should probably have been in the cc list. Whilst I might apply this directly >> as maintainer I much prefer if I get an ack from the driver author as if nothing >> else it gives me a warm fuzzy feeling ;) >> >> Also patch title should mention that a) this is a staging driver, b) which adc driver it >> applies to. I'll fix that up as well on applying it. >> >> Thanks for the patch though, it would probably never have been noticed otherwise! >> >>> Thanks. >>> > > > -- > Greetings, > Michael > > -- > Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen > Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; > Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, > Margaret Seif >
| |