Messages in this thread | | | Date | Mon, 9 Sep 2013 17:45:22 +0200 | From | Alexander Gordeev <> | Subject | Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface |
| |
On Mon, Sep 09, 2013 at 11:37:54AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Sep 09, 2013 at 05:20:44PM +0200, Alexander Gordeev wrote: > > The series is what it seems a direction to take. > > It can definitely use better descriptions explaining why this is > happening but the general direction seems good to me.
Oh, those are not even tested. Did not want turn to drivers before the interface/direction generally agreed.
> > Looks like we need PPC folks to agree on the quota check update > > for pSeries (yes, they do bail out with a positive return value > > from arch_msi_check_device()): > > > > quota = msi_quota_for_device(pdev, nvec); > > > > if (quota && quota < nvec) > > return quota; > > I think it should return -ENOSPC.
Absolutely, in patch #2 :)
> Thanks. > > -- > tejun
-- Regards, Alexander Gordeev agordeev@redhat.com
| |