Messages in this thread | | | Date | Mon, 9 Sep 2013 08:55:04 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] rcu: Is it safe to enter an RCU read-side critical section? |
| |
On Mon, 9 Sep 2013 14:45:49 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > This just proves that the caller of rcu_is_cpu_idle() must disable > > preemption itself for the entire time that it needs to use the result > > of rcu_is_cpu_idle(). > > Sorry, I don't understand your point here. What's wrong with checking the > ret from another CPU?
Hmm, OK, this is why that code is in desperate need of a comment.
From reading the context a bit more, it seems that the per cpu value is more a "per task" value that happens to be using per cpu variables, and changes on context switches. Is that correct?
Anyway, it requires a comment to explain that we are not checking the CPU state, but really the current task state, otherwise that 'ret' value wouldn't travel with the task, but would stick with the CPU.
-- Steve
| |