lkml.org 
[lkml]   [2013]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/2] max77693: added device tree support
    On Fri, Aug 23, 2013 at 10:08:39PM +0200, Tomasz Figa wrote:
    > On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote:

    > > +#ifdef CONFIG_OF
    > > +static struct of_device_id max77693_dt_match[] = {
    > > + {.compatible = "maxim,max77693"},
    > > + {},
    > > +};
    > > +#endif

    > As far as I'm aware of, you don't need explicit OF match table for I2C
    > devices, because the I2C OF core can use the array of struct i2c_device_id
    > pointed by .id_table field of struct i2c_driver.

    > I'm not sure if a separate OF table isn't preferred, though, so your patch
    > might be fine.

    It's still good practice to explicitly define a binding since that
    gives a vendor prefix and there are overlaps out there in chip vendor
    namings - for example both Wolfson and Wondermedia use "WMxxxx".
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-09-06 13:21    [W:4.128 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site