Messages in this thread | | | Date | Thu, 5 Sep 2013 20:07:19 +0200 | Subject | Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre) | From | Geert Uytterhoeven <> |
| |
On Thu, Sep 5, 2013 at 7:13 PM, Kyle McMartin <kyle@infradead.org> wrote: > On Thu, Sep 05, 2013 at 09:01:59AM -0700, James Bottomley wrote: >> > +EXPORT_SYMBOL_GPL(flush_cache_page); >> >> This is an internal API: no architecture exports this. Whoever is >> trying to use it needs to use the correct API, so this is the wrong >> patch. >> > > I suspect it's copy_{to,from}_user_page being called here:
Indeed. Sorry, I should have mentioned that.
> drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c: > copy_to_user_page(vma, page, addr, > > which we could probably take out of line.
If you want to hide flush_cache_page() for modules, yes.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |