Messages in this thread | | | Date | Thu, 5 Sep 2013 09:01:17 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *) |
| |
On Thu, Sep 05, 2013 at 09:21:54PM +0530, Avi wrote:
> >From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001 > From: AVI <avi@avi-VPCCW15FG.(none)>
Why have you attached your patch? And this "From:" line is obviously wrong :(
> Date: Thu, 5 Sep 2013 21:03:45 +0530 > Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)" > should be "(foo *)" > Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
You need to put some type of description in the changelog section.
And a new line before the signed-off-by: line.
Can you just use git send-email to send the patch, and not attach it, so that I don't have to hand-edit the patch in order to apply it properly?
thanks,
greg k-h
| |