lkml.org 
[lkml]   [2013]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] new fscache interface to check cache consistency
From
David,

Is there anyway I can call you at (at your desk) during EST hours. I'd
like to talk this part through since I think we're going a bit in
circles. I'd like to get this fixed so we can submit the fscache for
Ceph code for the upstream kernel in the merge window.

Best,
-- Milosz

On Wed, Sep 4, 2013 at 3:41 PM, Milosz Tanski <milosz@adfin.com> wrote:
> On Wed, Sep 4, 2013 at 2:13 PM, David Howells <dhowells@redhat.com> wrote:
>> Milosz Tanski <milosz@adfin.com> wrote:
>>
>>> Is it as simple as stick a mutex at the top of the
>>> __fscache_check_consistency function before we try to find the object?
>>
>> You can lock a mutex in a function, but where are you actually going to place
>> the mutex struct? And what other code is going to take it? To do this, you'd
>> have to place the mutex struct in fscache_cookie. The problem is that you
>> have to protect the pointer from fscache_cookie to fscache_object - so placing
>> the mutex in fscache_object doesn't help.
>
> David,
>
> I meant lock cookie->lock inside of __fscache_check_consistency in the
> beginning of the function. I don't see the need to push this into the
> netfs code.
>
> - Milosz


\
 
 \ /
  Last update: 2013-09-05 00:21    [W:0.224 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site